Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor grammatical fix in api_extra.rst #280

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

torokati44
Copy link
Contributor

No description provided.

@wjakob
Copy link
Owner

wjakob commented Aug 24, 2023

I don't see a grammatical problem. Can you point to a source saying why this expression is incorrect?

@torokati44
Copy link
Contributor Author

Sure:

https://www.grammarphobia.com/blog/2013/03/whether-or-not.html

Pat discusses this in her grammar and usage book Woe Is I. Here’s the passage:
“When you’re talking about a choice between alternatives, use whether: Richie didn’t know whether he should wear the blue suit or the green one. The giveaway is the presence of or between the alternatives. But when there’s a whether or not choice (Richie wondered whether or not he should wear his green checked suit), you can usually drop the or not and use either whether or if: Richie wondered if [or whether] he should wear his green checked suit. You’ll need or not, however, if your meaning is ‘regardless of whether’: Richie wanted to wear the green one, whether it had a gravy stain or not. (Or, if you prefer, whether or not it had a gravy stain.)”

https://dictionary.cambridge.org/dictionary/english/whether-or-not

used for saying that it is not important which of two possibilities is true


The "whether or not" phrasing, at least to me, means:

  • either that it doesn't matter which case it is, which is not right in the corrected sentence,
  • or that the two possibilities are logical opposites (with only one of them written down), which is also not the case.

The corrected sentence presents two alternatives (self on the left side vs. self on the right side), in which case a simple "whether" is more appropriate in my opinion.
Of course, one could argue that left and right are logical opposites, but in that sentence, both using "whether or not", and then spelling out the two alternatives, comes across as strange to me.
It would also be fine as "Depending on whether or not self is the left argument of a binary operation", but I think the other variant fits better here.

@wjakob
Copy link
Owner

wjakob commented Aug 25, 2023

Got it, that makes sense -- thank you. Could you rebase the PR based on master? Looks like it bundles some unrelated changes.

@torokati44
Copy link
Contributor Author

torokati44 commented Aug 25, 2023

Looks like it bundles some unrelated changes.

I have no idea how that happened, but sure.

EDIT: + 23ea320...64d87ae master -> origin/master (forced update) <- Looks like master got amended since I submitted this, that is why.

@wjakob wjakob merged commit c922753 into wjakob:master Aug 25, 2023
21 checks passed
@wjakob
Copy link
Owner

wjakob commented Aug 25, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants